Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docker images with z3 4.11.2 #13738

Merged
merged 1 commit into from
Nov 24, 2022
Merged

update docker images with z3 4.11.2 #13738

merged 1 commit into from
Nov 24, 2022

Conversation

leonardoalt
Copy link
Member

@leonardoalt leonardoalt commented Nov 23, 2022 •
edited
Loading

The flow in updating z3 is the following:

  1. Someone needs to push new PPA builds with the new version, in https://launchpad.net/~ethereum/+archive/ubuntu/cpp-build-deps/+packages
  2. When they are built, open a PR (PR1) like this one bumping the dockerfile versions and updating the z3 version where applicable
  3. When the new images are built, the bot will post the 4 new hashes here. In a different PR (PR2) (now this was done in update SMTChecker tests with Z3 4.11.2 #13740):
    • Update the docker hashes
    • Update the z3 version in .circleci/osx_install_dependencies.sh
    • Update the SMT tests
  4. Merge PR2
  5. Rebase PR1, merge PR1.
  6. Done

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:emscripten-14 [solbuildpackpusher/solidity-buildpack-deps@sha256:d7d4ec28cdc3e61fc6a048b88ebdff1c5e67f3353cf1739cbaea07ec2481eb16].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu1604.clang.ossfuzz-21 [solbuildpackpusher/solidity-buildpack-deps@sha256:ae6b695fb8a0806702bb6a1a9616fbb33ac3288f25990fa799aab2c045c80ea1].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-16 [solbuildpackpusher/solidity-buildpack-deps@sha256:8f635529a10e0ddf955d6d72360261966e5fee0b5c5211070370ca2fc4e0ab7c].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-16 [solbuildpackpusher/solidity-buildpack-deps@sha256:ee1def5806f40c35d583234e172ec5769bb9a08b6f5bbc713c1a2658846dbced].

@cameel cameel assigned r0qs and nishant-sachdeva and unassigned r0qs and nishant-sachdeva Nov 23, 2022
@r0qs r0qs self-requested a review November 24, 2022 14:01
r0qs
r0qs approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass.

@leonardoalt leonardoalt merged commit 0f3e7af into develop Nov 24, 2022
@leonardoalt leonardoalt deleted the z3_4_11_2_docker branch November 24, 2022 14:47
@blishko blishko mentioned this pull request Oct 31, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0qs r0qs r0qs approved these changes

@nishant-sachdeva nishant-sachdeva Awaiting requested review from nishant-sachdeva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardoalt @r0qs @nishant-sachdeva