Add test for via-ir codegen import bug #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
added
the
has dependencies
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
from
b7abadf to
ab070ad
Compare
r0qs
force-pushed
the
fix-viaIR-codegen-import-bug
branch
from
6315b07 to
071bb35
Compare
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
5 times, most recently
from
0e73776 to
0015e43
Compare
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
2 times, most recently
from
5dd2456 to
0448a3c
Compare
r0qs
changed the title
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
2 times, most recently
from
1d85d18 to
0396dc0
Compare
cameel
reviewed
Sep 19, 2023
test/cmdlineTests/~bytecode_equivalence_multiple_sources/test.py
Outdated
Show resolved
Hide resolved
cameel
reviewed
Sep 19, 2023
test/cmdlineTests/~bytecode_equivalence_multiple_sources/test.py
Outdated
Show resolved
Hide resolved
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
2 times, most recently
from
2001415 to
975b71b
Compare
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
from
975b71b to
79cac06
Compare
r0qs
force-pushed
the
fix-viaIR-codegen-import-bug
branch
2 times, most recently
from
f2e2232 to
fc49295
Compare
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
from
79cac06 to
41719ca
Compare
cameel
reviewed
Sep 25, 2023
test/cmdlineTests/~bytecode_equivalence_multiple_sources/test.py
Outdated
Show resolved
Hide resolved
scripts/common/git_helpers.py
Outdated
| subprocess.check_output( | ||
| f"""\ | ||
| git diff \ | ||
| --color \ |
There was a problem hiding this comment.
Nice. I wanted to complain that this may not work on all platforms, but I guess it should be fine since it's git diff and not the crappy diff included by default with macOS, which does not seem to support --color. Maybe we should later switch to using git for diffing in our Bash scripts too.
test/cmdlineTests/~bytecode_equivalence_multiple_sources/inputs.sol
Outdated
Show resolved
Hide resolved
cameel
reviewed
Sep 25, 2023
test/cmdlineTests/~bytecode_equivalence_multiple_sources/inputs.sol
Outdated
Show resolved
Hide resolved
cameel
reviewed
Sep 25, 2023
test/cmdlineTests/~bytecode_equivalence_multiple_sources/inputs.sol
Outdated
Show resolved
Hide resolved
r0qs
force-pushed
the
fix-viaIR-codegen-import-bug
branch
from
ca75a35 to
e3b36f7
Compare
r0qs
commented
Sep 26, 2023
r0qs
force-pushed
the
viaIR-codegen-import-bug-test
branch
4 times, most recently
from
31bedce to
18e0de7
Compare
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
cameel
force-pushed
the
viaIR-codegen-import-bug-test
branch
from
18e0de7 to
ab2d395
Compare
cameel
approved these changes
Sep 29, 2023
cameel
removed
the
has dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #14562. This PR adds a CLI test case for the bug reported at #14541 as suggested by #14562 (comment). It is a simplification of the following example: #14541 (comment)