-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[soltest] Add support for left-aligned hex literals #6036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6036 +/- ##
===========================================
+ Coverage 88.66% 88.69% +0.03%
===========================================
Files 368 368
Lines 34956 35031 +75
Branches 4131 4133 +2
===========================================
+ Hits 30992 31070 +78
+ Misses 2573 2568 -5
- Partials 1391 1393 +2
|
chriseth
suggested changes
Feb 19, 2019
2bc0b6c
to
15bc101
Compare
Updated. Hex number literals with an odd number of digits now throw an exception and character checking is shared in the |
Will push an update very soon, that does not decrease coverage. |
82b1e0d
to
d02a26d
Compare
d02a26d
to
ecf21ff
Compare
54d6804
to
cdf2759
Compare
1 task
92e0b99
to
d1ad431
Compare
ecf21ff
to
d40928f
Compare
Rebased. |
chriseth
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4223.
develop
after [soltest] Create dedicated formatting #6060 got mergedThis PR aims to add support for hex literals in (i)soltest. Hex literals result in a left-aligned, padded 32-byte representation:
Decimal number literals are still right-aligned, padded 32 bytes.
This PR also moves some code that is shared between the Solidity parser and the soltest parser.