[soltest] Share code with langutil #6059
Merged
+71
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6059 +/- ##
===========================================
- Coverage 88.33% 88.33% -0.01%
===========================================
Files 361 362 +1
Lines 34866 34864 -2
Branches 4131 4131
===========================================
- Hits 30798 30796 -2
Misses 2693 2693
Partials 1375 1375
|
1 task
chriseth
reviewed
Feb 21, 2019
| @@ -0,0 +1,63 @@ | |||
| /* | |||
There was a problem hiding this comment.
What about CharClasses.h?
There was a problem hiding this comment.
Ah, then hexValue would not fit. hm.
chriseth
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring splitted out of #6036.