Add multicoin support for ENS / AsyncENS address() and setup_address()
#3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
update-ens-resolver
branch
from
95053c0
to
d332e8d
Compare
fselmo
changed the title
address() and setup_address()
fselmo
force-pushed
the
update-ens-resolver
branch
5 times, most recently
from
fb98eb5
to
fdca2b8
Compare
fselmo
force-pushed
the
update-ens-resolver
branch
from
fdca2b8
to
95f4bcd
Compare
reedsa
reviewed
Jul 12, 2023
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jul 12, 2023
- Update unternal ENS contracts to use the dynamically compiled (latest) contract data rather than static values that need to be manually updated.
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jul 12, 2023
fselmo
force-pushed
the
update-ens-resolver
branch
from
138df62
to
1437108
Compare
fselmo
force-pushed
the
update-ens-resolver
branch
from
1437108
to
3399587
Compare
|
@reedsa, did you get a chance to see my comments here? Let me know if your original comments were all addressed 👀 |
reedsa
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Extended support for ENSIP-9 Multichain Address Resolution via ENS / AsyncENS
address()andsetup_address()methodscloses #1839
How was it fixed?
ns.address(name, coin_type=coin_type)+ns.setup_address(name, address, coin_type=coin_type, transact=transact)ens/ens.pyandens/async_ens.pyweb3/_utils/contract_sources/contract_datarather than using static values for bytecode, abi, etc.--
Note: This originally aimed to add more methods but those seem unnecessary when users can already interact with the resolver contract via the updated ABI from #2700
Todo:
address()andsetup_address()Cute Animal Picture