Skip to content

Commit

Permalink
Changes from comments on PR ethereum#3030 & minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
fselmo committed Jul 12, 2023
1 parent 95f4bcd commit 138df62
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions ens/async_ens.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def from_web3(cls, w3: "AsyncWeb3", addr: ChecksumAddress = None) -> "AsyncENS":
async def address(
self,
name: str,
coin_type: int = None,
coin_type: Optional[int] = None,
) -> Optional[ChecksumAddress]:
"""
Look up the Ethereum address that `name` currently points to.
Expand Down Expand Up @@ -170,7 +170,7 @@ async def setup_address(
address: Union[Address, ChecksumAddress, HexAddress] = cast(
ChecksumAddress, default
),
coin_type: int = None,
coin_type: Optional[int] = None,
transact: Optional["TxParams"] = None,
) -> Optional[HexBytes]:
"""
Expand All @@ -186,6 +186,7 @@ async def setup_address(
:param str address: name will point to this address, in checksum format.
If ``None``, erase the record. If not specified, name will point
to the owner's address.
:param int coin_type: if provided, set up the address for this coin type
:param dict transact: the transaction configuration, like in
:meth:`~web3.eth.Eth.send_transaction`
:raises InvalidName: if ``name`` has invalid syntax
Expand Down
2 changes: 2 additions & 0 deletions ens/contract_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
This contract data is taken form the actual ENS contracts deployed on mainnet.
The information was taken from etherscan.io and may need to be updated as the ENS
contracts are updated.
https://etherscan.io/accounts/label/ens
"""

# ENS Default Registrar
Expand Down
2 changes: 1 addition & 1 deletion ens/ens.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def setup_address(
:param str address: name will point to this address, in checksum format.
If ``None``, erase the record. If not specified, name will point
to the owner's address.
:param int coin_type: if provided, set the address for this coin type
:param int coin_type: if provided, set up the address for this coin type
:param dict transact: the transaction configuration, like in
:meth:`~web3.eth.Eth.send_transaction`
:raises InvalidName: if ``name`` has invalid syntax
Expand Down

0 comments on commit 138df62

Please sign in to comment.