[WIP] Metropolis: EIP86 account abstraction #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
commented
Apr 12, 2017
Paper.tex
Outdated
| \boldsymbol{\sigma}_0[S(T)]_n & \equiv & \boldsymbol{\sigma}[S(T)]_n + 1 | ||
| \boldsymbol{\sigma}_0[S(T)]_n & \equiv & | ||
| \begin{cases} | ||
| \boldsymbol{\sigma}[S(T)]_n &\text{if}\ S(T) = 2^{256} \\ |
There was a problem hiding this comment.
I guess the number should be 2^{256} - 1.
gavofyork
reviewed
Apr 12, 2017
Paper.tex
Outdated
| @@ -609,7 +613,11 @@ \subsection{Execution} | |||
| \begin{equation} | |||
| g \equiv T_g - g_0 | |||
| \end{equation} | |||
| and $T_o$ is the original transactor, which can differ from the sender in the case of a message call or contract creation not directly triggered by a transaction but coming from the execution of EVM-code. | |||
| and $T_o$ is the original transactor, which can differ from the sender in the case of a message call or contract creation not directly triggered by a transaction but coming from the execution of EVM-code. $a$ is the address of the created account: | |||
There was a problem hiding this comment.
superfluous double-space
gavofyork
reviewed
Apr 12, 2017
Paper.tex
Outdated
| \begin{equation} \label{eq:address_calc} | ||
| a \equiv \mathcal{B}_{96..255}\Big(\mathtt{\tiny KEC}\big(0 \cdot \mathbf{i}\big)\Big) | ||
| \end{equation} | ||
| where $0$ denotes the zero element of $\mathbb{B}_{160}$, the operator $\cdot$ is the concatenation of binary data, $\mathtt{\tiny KEC}$ is the Keccak 256-bit hash function, $\mathcal{B}_{a..b}(X)$ evaluates to binary value containing the bits of indices in the range $[a, b]$ of the binary data. |
There was a problem hiding this comment.
better not to "denote" 0 to be anything other than zero. if you want to pun it into a particular element of a set, better to use some other notation.
gavofyork
reviewed
Apr 12, 2017
Paper.tex
Outdated
| and $T_o$ is the original transactor, which can differ from the sender in the case of a message call or contract creation not directly triggered by a transaction but coming from the execution of EVM-code. | ||
| and $T_o$ is the original transactor, which can differ from the sender in the case of a message call or contract creation not directly triggered by a transaction but coming from the execution of EVM-code. $a$ is the address of the created account: | ||
| \begin{equation} \label{eq:address_calc} | ||
| a \equiv \mathcal{B}_{96..255}\Big(\mathtt{\tiny KEC}\big(0 \cdot \mathbf{i}\big)\Big) |
There was a problem hiding this comment.
should read ...KEC(\mathbf{i})...
gavofyork
reviewed
Apr 12, 2017
Paper.tex
Outdated
| 0xfb & {\small CREATE\_P2SH} & 3 & 1 & Create a new account with associated code on an address calculated using the \\ | ||
| &&&& creator's address. \\ | ||
| &&&& Exactly equivalent to {\small CREATE} except: \\ | ||
| &&&& $a \equiv \mathcal{B}_{96..255}\Big(\mathtt{\tiny KEC}\big(I_a \cdot \mathbf{i}\big)\Big)$ \\ |
There was a problem hiding this comment.
should read ...KEC(\mathbf{i})...
|
Addressed the comments. |
pirapira
changed the title
|
Probably there will be a conflict with #278. |
pirapira
changed the title
pirapira
commented
May 11, 2017
Paper.tex
Outdated
| \boldsymbol{\sigma}^{**} & \text{if} \quad g^{**}<c \wedge H_i<\firsthomesteadblock \\ | ||
| \boldsymbol{\sigma}^{**} \quad \text{except:} & \\ | ||
| \quad\boldsymbol{\sigma}'[a]_c = \texttt{\small KEC}(\mathbf{o}) & \text{otherwise} | ||
| \end{cases} | ||
| \end{cases} \\ | ||
| E(\boldsymbol{\sigma}, a) &\equiv \big(\boldsymbol{\sigma}[a] \neq \varnothing \wedge (\boldsymbol{\sigma}[a]_c \neq () \vee \boldsymbol{\sigma}[a]_n \neq 0)\big) |
There was a problem hiding this comment.
The empty code is seen as KEC(()) not just ().
|
This PR needs to follow ethereum/EIPs@bd136e6 |
but only when the gas price, the nonce and the value are all zero.
The function \Lambda now takes the new address as a parameter
|
I finished applying ethereum/EIPs@bd136e6 |
|
This protocol change has been postponed and I don't know when it is planned. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ethereum/EIPs#208 as part of the Metropolis changes. #229
This is a reincarnation of #249, but reflects a recent change in ethereum/EIPs#208.