-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockchain reorganization #1980
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the blockchain.ts
file has lost its history, this would need to be re-applied I guess.
So the procedure would be: do a first commit renaming index.ts
to blockchain.ts
. And then do a second creating and adding a new index.ts
just with the exports.
Otherwise we would loose the whole index.ts
file and change history.
Does this make sense or am I missing something?
I followed the path you suggested in #1981 and it looks like it did the same thing. Does it look any different to you? |
Did you move natively with git, so with |
Ah, no, I didn't even realize that existed. Learn something new every day. Will close this PR and open a new one done under that approach. |
Reorganizes
blockchain
to only do exportsindex.ts
blockchain
class and its opts are moved toblockchain.ts