Blockchain file reorganization

[acolytec3]

No description provided.

[acolytec3]

@holgerd77 How does this version look? Sorry, this whole land of renaming files while preserving history is brand new to me. I used Gitlens on VS Code locally and it looks like it's now retaining the history of the renamed blockchain.ts file now

[codecov]

Codecov Report

Merging #1986 (7809371) into master (1bd5c4f) will decrease coverage by 5.42%.
The diff coverage is 76.21%.

Flag	Coverage Δ
block	84.30% <ø> (?)
blockchain	81.03% <76.21%> (+0.02%)	⬆️
client	78.34% <ø> (?)
common	95.01% <ø> (?)
devp2p	82.64% <ø> (?)
ethash	90.81% <ø> (ø)
evm	42.62% <ø> (?)
statemanager	84.55% <ø> (?)
trie	73.72% <ø> (ø)
tx	92.17% <ø> (?)
util	87.03% <ø> (?)
vm	76.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

Thanks, that looks good, I guess GitHub won't show this any better. 🙂

Are you also adding a types.ts file and moving types, options,... in? That would be great!

Do we have anything else?

[acolytec3]

Thanks, that looks good, I guess GitHub won't show this any better. slightly_smiling_face

Are you also adding a types.ts file and moving types, options,... in? That would be great!

Do we have anything else?

I moved the types from blockchain.ts into their own file in the package/src directory. Is there any reason to bring the consensus or genesisState types into the master types.ts file? It feels pretty well compartmentalized to me.

[holgerd77]

I moved the types from blockchain.ts into their own file in the package/src directory. Is there any reason to bring the consensus or genesisState types into the master types.ts file? It feels pretty well compartmentalized to me.

Yeah, maybe we just leave there. Thanks, looks all good! 🙂

[holgerd77]

LGTM

[jochem-brouwer]

It looks like git history of the files is lost here, did you use git mv here?

[acolytec3]

I tried, and tried, and tried, and tried. 😅

[holgerd77]

I tried, and tried, and tried, and tried. 😅

🙂 😂

Yes, impressively hard stuff. Strange sometimes.