-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istanbul Draft EIP-1108 Support #540
Conversation
… reliable Istanbul development
… precompiles for Istanbul comparison
2aefd91
to
adcfc76
Compare
Ok, this is now ready for review. I've added some API tests for the precompiles touched in a separate I also added these tests as regular precompile tests running against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those tests look great, thanks Holger 😄
Thanks, I can really need some kind words the few times I'm doing something directly productive! 😋 |
Addresses #539.
WIP, first push to run the tests againstethereumjs-common
v1.2.1.I think for the time of Istanbul development we should fix the common dependency version (have done this here) to have more predictable Istanbul behavior since EIPs might change and we don't want to do major version bump for every change here over on the
Common
side.