Implements scoped packages #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
evertonfraga
force-pushed
the
scoped-packages
branch
from
5b87e57 to
0866c46
Compare
|
(Merging to a branch other than |
evertonfraga
added a commit
that referenced
this pull request
Jun 2, 2020
* Readme package renaming * account: renaming package * block: Migrating to scoped packages * npm package URL * block: updating dependencies to scoped packages * blockchain: migrating to scoped packages * common: migrating to scoped packages * tx: migrating to scoped packages * vm: migrating to scoped packages * account,block: updating badges * vm: updating patch to scoped packages * fix: updating new occurrences of package names * fix: updating new occurrences of package names * fix: rebase re-touching * ci: updating Block ci file
Merged
evertonfraga
added a commit
that referenced
this pull request
Jun 9, 2020
* Readme package renaming * account: renaming package * block: Migrating to scoped packages * npm package URL * block: updating dependencies to scoped packages * blockchain: migrating to scoped packages * common: migrating to scoped packages * tx: migrating to scoped packages * vm: migrating to scoped packages * account,block: updating badges * vm: updating patch to scoped packages * fix: updating new occurrences of package names * fix: updating new occurrences of package names * fix: rebase re-touching * ci: updating Block ci file
evertonfraga
added a commit
that referenced
this pull request
Jun 10, 2020
* Readme package renaming * account: renaming package * block: Migrating to scoped packages * npm package URL * block: updating dependencies to scoped packages * blockchain: migrating to scoped packages * common: migrating to scoped packages * tx: migrating to scoped packages * vm: migrating to scoped packages * account,block: updating badges * vm: updating patch to scoped packages * fix: updating new occurrences of package names * fix: updating new occurrences of package names * fix: rebase re-touching * ci: updating Block ci file
evertonfraga
added a commit
that referenced
this pull request
Jun 10, 2020
* Readme package renaming * account: renaming package * block: Migrating to scoped packages * npm package URL * block: updating dependencies to scoped packages * blockchain: migrating to scoped packages * common: migrating to scoped packages * tx: migrating to scoped packages * vm: migrating to scoped packages * account,block: updating badges * vm: updating patch to scoped packages * fix: updating new occurrences of package names * fix: updating new occurrences of package names * fix: rebase re-touching * ci: updating Block ci file downgrading nyc in block
holgerd77
reviewed
Jun 10, 2020
| - run: npx lerna run build --scope @ethereumjs/block --include-dependencies | ||
| - run: npx lerna run lint --scope @ethereumjs/block | ||
| - run: npx lerna run test:node --scope @ethereumjs/block | ||
| - run: npx lerna run test:browser --scope @ethereumjs/block |
There was a problem hiding this comment.
Why are the test commands run in a lerna context here?
There was a problem hiding this comment.
This is to avoid repetition of working-directory: property of run:.
In GH actions, each run command is executed in a new context. That makes impossible to have: run: cd packages/vm at the beginning of the script, and run the remaining commands from that directory. GitHub's solution is the working-directory: property that you have to use for every run: command.
Lerna allows to run npm scripts straight from the repository root, so we don't need to mingle with cd or working-directory code.
On another track, I've been doing some work to improve the developer experience of this monorepo, and these very commands could be replaced by shorter versions as well.
From:
npx lerna bootstrap --scope @ethereumjs/block --ignore-scripts --include-dependencies --no-ci
to:
npm run bootstrap @ethereumjs/block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts package names to scoped packages at every level of the monorepo project.
Note: It merges to
vm/release-v5branch.