-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements scoped packages #679
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6484e3d
Readme package renaming
evertonfraga 53c64c2
account: renaming package
evertonfraga 94808c6
block: Migrating to scoped packages
evertonfraga 7c88c83
npm package URL
evertonfraga 09a1b83
block: updating dependencies to scoped packages
evertonfraga 88ccadf
blockchain: migrating to scoped packages
evertonfraga c1bd59d
common: migrating to scoped packages
evertonfraga 36fc190
tx: migrating to scoped packages
evertonfraga 859bf37
vm: migrating to scoped packages
evertonfraga 7440612
account,block: updating badges
evertonfraga 0866c46
vm: updating patch to scoped packages
evertonfraga 039e50a
fix: updating new occurrences of package names
evertonfraga d1d8200
fix: updating new occurrences of package names
evertonfraga b0b42cb
fix: rebase re-touching
evertonfraga f017dbd
ci: updating Block ci file
evertonfraga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the test commands run in a
lerna
context here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to avoid repetition of
working-directory:
property ofrun:
.In GH actions, each
run
command is executed in a new context. That makes impossible to have:run: cd packages/vm
at the beginning of the script, and run the remaining commands from that directory. GitHub's solution is theworking-directory:
property that you have to use for everyrun:
command.Lerna allows to run npm scripts straight from the repository root, so we don't need to mingle with
cd
orworking-directory
code.On another track, I've been doing some work to improve the developer experience of this monorepo, and these very commands could be replaced by shorter versions as well.
From:
npx lerna bootstrap --scope @ethereumjs/block --ignore-scripts --include-dependencies --no-ci
to:
npm run bootstrap @ethereumjs/block