-
Notifications
You must be signed in to change notification settings - Fork 273
Conversation
This pull request introduces 1 alert when merging 0b7b413 into 3141eda - view on LGTM.com new alerts:
|
0b7b413
to
e221440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case to discuss/adopt, otherwise looks good, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case to discuss/adopt, otherwise looks good, thanks!
This pull request introduces 1 alert when merging c7d016d into 3141eda - view on LGTM.com new alerts:
|
c7d016d
to
296e5aa
Compare
296e5aa
to
dbda438
Compare
This pull request introduces 1 alert when merging dbda438 into 3141eda - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me know, will merge.
Part of #172 Breaking API changes
Makes
keccak
,sha256
andripemd160
buffer-only and addsfromString
andfromArray
variants for those inputs.Adds
assertIsBuffer
check to input ofhashPersonalMessage
(excluding the possibility that someone could submit an array).Notes:
There are more methods in
signature.ts
which could have their params validated but overall that file seems to have clearly specified input types.In adding convenience methods, I omitted
number
because idk if that's really used. However, this has been a valid input to the hash methods.