when confirmation is zero it should return the receipt straight away

[wighawag]

Ethers Version

git

Search Terms

transaction,wait

Describe the Problem

here it do an extra query to see check for confirmations:

ethers.js/src.ts/providers/provider.ts

Line 1466 in 1dd5427

if ((await receipt.confirmations()) >= confirms) { return receipt; }

if the confirmation number is zero it should return the receipt directly

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

node.js (v12 or newer), Hardhat

Environment (Other)

No response

[ricmoo]

If confirmations is is 0, then any value will be >= confirmations. If .confirmations() is negative then that’s a bug.

[ricmoo]

Oh! It doesn’t need to await though. Fair enough. I’ll get it in the next patch release.

[ricmoo]

@Harsh8055 Sure! I’ve already made the change locally, but I haven’t committed it yet. So, I can tag your PR in the commit so you get your GitPOAP and info added to the contributors list. :)

[wighawag]

If confirmations is is 0, then any value will be >= confirmations. If .confirmations() is negative then that’s a bug.

It definitely does in some cases, see issue: #4224 (comment)

I even seen less than -1. I ll see if i can make a repro case and i ll create a separate issue

But yes if confirmations is zero there should be no need to await and check anyway

[ricmoo]

Fixed in v6.6.4.

Thanks! :)