Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for blockscout #372

Closed
h4ck3rk3y opened this issue Nov 28, 2023 · 8 comments
Closed

add support for blockscout #372

h4ck3rk3y opened this issue Nov 28, 2023 · 8 comments
Labels
good first issue Good for newcomers

Comments

@h4ck3rk3y
Copy link
Collaborator

No description provided.

@franjoespejo
Copy link
Contributor

franjoespejo commented Nov 28, 2023 •
edited
Loading

Really convenient for us at Shamir Labs, specially if the https://docs.blockscout.com/for-developers/information-and-settings/smart-contract-verification module is enabled

@barnabasbusa barnabasbusa added the good first issue Good for newcomers label Nov 28, 2023
@barnabasbusa
Copy link
Contributor

@franjoespejo would you consider contributing this tooling ?

@franjoespejo
Copy link
Contributor

franjoespejo commented Nov 28, 2023 •
edited
Loading

Thanks @barnabasbusa! would love but we cannot commit to it atm. We are arranging things to contribute very soon, would take this ticket if it is still open

@igor-ritual
Copy link

Working rough draft: main...igor-ritual:ethereum-package:blockscout

@barnabasbusa
Copy link
Contributor

I'd recommend not having this package enabled by default, but make it an optionally configurable package.

Feel free to open a PR when you feel like its ready for review.

@barnabasbusa
Copy link
Contributor

Would you please add mem/cpu requests/limits to the application? Similar to #396

@franjoespejo
Copy link
Contributor

working on it, will enable sc verification as well

This was referenced Jan 30, 2024
Closed
Merged
barnabasbusa pushed a commit that referenced this issue Feb 2, 2024
@franjoespejo
feat: blockscout support with sc verification (#481)
b3418cf 
addresses #372

---------

Co-authored-by: franjoespejo <franjosepejo@github.com>
bharath-123 pushed a commit to bharath-123/eth2-package that referenced this issue Feb 18, 2024
@franjoespejo @bharath-123
feat: blockscout support with sc verification (ethpandaops#481)
456d0bc 
addresses ethpandaops#372

---------

Co-authored-by: franjoespejo <franjosepejo@github.com>
@barnabasbusa
Copy link
Contributor

This is now merged with #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@h4ck3rk3y @franjoespejo @barnabasbusa @igor-ritual