Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blockscout support with sc verification #481

Merged
merged 8 commits into from
Feb 2, 2024
Merged

feat: blockscout support with sc verification #481

merged 8 commits into from
Feb 2, 2024

Conversation

franjoespejo
Copy link
Contributor

addresses #372

@franjoespejo franjoespejo changed the title Blockscout support with sc verification feat: Blockscout support with sc verification Jan 31, 2024
@franjoespejo
Copy link
Contributor Author

@barnabasbusa pls note:

  • blockscout execution block explorer not activated by default
  • up to date with latest changes in main
  • resources limit values are just a guess
  • not sure if its ok to return the 'blockscout verification url' from the main function so can be used in the diva-package that calls this eth-package

@franjoespejo franjoespejo changed the title feat: Blockscout support with sc verification feat: blockscout support with sc verification Jan 31, 2024
@barnabasbusa
Copy link
Contributor

Could you add blockscout to a couple of the tests ?

  • .github/tests/mix-with-tools.yaml
  • .github/tests/mix-with-tools-mev.yaml

Do you see a value in enabling persistent storage for this tool (if users asks for persistence) ?

@franjoespejo
Copy link
Contributor Author

right, will do test and persistence!

@franjoespejo
Copy link
Contributor Author

I also returned the url for the verification sc service, pls check, I can rm if needed

@barnabasbusa
Copy link
Contributor

Screenshot 2024-02-02 at 11 56 09

Things look pretty good, I'm just getting Failed to decode input data. for most blocks.

@barnabasbusa barnabasbusa enabled auto-merge (squash) February 2, 2024 11:54
@barnabasbusa
Copy link
Contributor

This probably has more to do with the image than with kurtosis config, so lets merge this.

@barnabasbusa barnabasbusa merged commit b3418cf into ethpandaops:main Feb 2, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
h4ck3rk3y pushed a commit that referenced this pull request Feb 12, 2024
@github-actions
chore(main): release 1.4.0 (#473)
5602a02 
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](1.3.0...1.4.0)
(2024-02-09)


### Features

* Add suave-enabled geth support
([#489](#489))
([631eaf3](631eaf3))
* add support for custom assertoor images & use assertoor image with
verkle support for verkle chains
([#483](#483))
([2d8a143](2d8a143))
* add verkle-gen-devnet-3
([#487](#487))
([1e543e8](1e543e8))
* blockscout support with sc verification
([#481](#481))
([b3418cf](b3418cf))
* enable custom resource limit per network
([#471](#471))
([5db6611](5db6611))
* enable shadowforking
([#475](#475))
([b788b18](b788b18))
* improve built-in assertoor tests
([#488](#488))
([d596699](d596699))
* we no longer need 4788 deployer
([#485](#485))
([abdfc2c](abdfc2c))


### Bug Fixes

* add more prefund addresses for verkle-gen
([#482](#482))
([01868fc](01868fc))
* bump verkle genesis generator
([#486](#486))
([79dc5e1](79dc5e1))
* use latest stable image for assertoor
([#484](#484))
([bbe0b16](bbe0b16))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bharath-123 pushed a commit to bharath-123/eth2-package that referenced this pull request Feb 18, 2024
@franjoespejo @bharath-123
feat: blockscout support with sc verification (ethpandaops#481)
456d0bc 
addresses ethpandaops#372

---------

Co-authored-by: franjoespejo <franjosepejo@github.com>
bharath-123 pushed a commit to bharath-123/eth2-package that referenced this pull request Feb 18, 2024
@github-actions @bharath-123
chore(main): release 1.4.0 (ethpandaops#473)
7854d77 
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](ethpandaops/ethereum-package@1.3.0...1.4.0)
(2024-02-09)


### Features

* Add suave-enabled geth support
([ethpandaops#489](ethpandaops#489))
([631eaf3](ethpandaops@631eaf3))
* add support for custom assertoor images & use assertoor image with
verkle support for verkle chains
([ethpandaops#483](ethpandaops#483))
([2d8a143](ethpandaops@2d8a143))
* add verkle-gen-devnet-3
([ethpandaops#487](ethpandaops#487))
([1e543e8](ethpandaops@1e543e8))
* blockscout support with sc verification
([ethpandaops#481](ethpandaops#481))
([b3418cf](ethpandaops@b3418cf))
* enable custom resource limit per network
([ethpandaops#471](ethpandaops#471))
([5db6611](ethpandaops@5db6611))
* enable shadowforking
([ethpandaops#475](ethpandaops#475))
([b788b18](ethpandaops@b788b18))
* improve built-in assertoor tests
([ethpandaops#488](ethpandaops#488))
([d596699](ethpandaops@d596699))
* we no longer need 4788 deployer
([ethpandaops#485](ethpandaops#485))
([abdfc2c](ethpandaops@abdfc2c))


### Bug Fixes

* add more prefund addresses for verkle-gen
([ethpandaops#482](ethpandaops#482))
([01868fc](ethpandaops@01868fc))
* bump verkle genesis generator
([ethpandaops#486](ethpandaops#486))
([79dc5e1](ethpandaops@79dc5e1))
* use latest stable image for assertoor
([ethpandaops#484](ethpandaops#484))
([bbe0b16](ethpandaops@bbe0b16))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@barnabasbusa barnabasbusa mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnabasbusa barnabasbusa barnabasbusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franjoespejo @barnabasbusa