fix: Remove wait for finalization for create2 factory deployment #60
+26
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
reviewed
Aug 19, 2024
Comment on lines
-34
to
-35
| # Install web3 cli | ||
| RUN curl -LSs https://raw.githubusercontent.com/gochain/web3/master/install.sh | sh |
There was a problem hiding this comment.
gud, this installation has occasionally failed for my setup
| @@ -1,4 +1,4 @@ | |||
| IMAGE = "ethpandaops/optimism-contract-deployer:latest" | |||
There was a problem hiding this comment.
we prob want to ask PandaOps team to rebuild this
There was a problem hiding this comment.
Would be able to rebuild, once the PR branch (cl/latest-getting-started) is merged in.
|
I'm getting for the contract deployment. |
Dockerfile
Outdated
| # Install foundry | ||
| RUN curl -L https://foundry.paradigm.xyz | bash | ||
| ENV PATH="/root/.foundry/bin:${PATH}" | ||
| RUN foundryup -v nightly-626221f5ef44b4af950a08e09bd714650d9eb77d |
There was a problem hiding this comment.
is there something new in the nightly foundry that we need?
There was a problem hiding this comment.
Nothing specific; The OP monorepo pins the version of foundry it uses, see here. Just pinned it to the same in case there are any changes in artifact format, etc., as to not break op-node's expectations for reading from the artifacts during L2 genesis generation.
There was a problem hiding this comment.
^ Same with the go version btw; Monorepo currently pins 1.21.1
There was a problem hiding this comment.
we should probably try to query the version rather than rely on manual updates from our side
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org> Signed-off-by: clabby <ben@clab.by>
|
op geth has been rebased on geth, which defaults to path based storage (which is currently incompatible with archive mode). Therefore, #61 has to be first merged before the CI would pass on this PR. |
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
…ckage into cl/finalized-wait-fix
barnabasbusa
approved these changes
Aug 22, 2024
barnabasbusa
added a commit
that referenced
this pull request
Nov 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](1.0.0...1.1.0) (2024-11-21) ### Features * add additional configuration options for participants ([#81](#81)) ([05d0fe9](05d0fe9)) * add custom configurable forks ([#59](#59)) ([878906a](878906a)) * add hildr ([#42](#42)) ([e1ce08e](e1ce08e)) * add k8s tests ([#45](#45)) ([168f062](168f062)) * add op_contract_deployer_params/image ([#63](#63)) ([9416a86](9416a86)) * add op-besu ([#58](#58)) ([08e7548](08e7548)) * add op-erigon - mininny ([#38](#38)) ([c69bf34](c69bf34)) * add sanity check ([#50](#50)) ([ceaa9a9](ceaa9a9)) * Add support for op-deployer, fix multiple L2s ([#74](#74)) ([eb59380](eb59380)) * add version.txt ([#36](#36)) ([1d10311](1d10311)) * add wait for sync for non kurtosis chains ([#49](#49)) ([0452e11](0452e11)) * Adding op-nethermind ([#46](#46)) ([fba71dd](fba71dd)) * op-deployer upgrade, fix fork support ([#88](#88)) ([f8d9089](f8d9089)) * Output Admin Private Key ([#71](#71)) ([95abc10](95abc10)) ### Bug Fixes * ci jobs only notify if discord secret available ([#48](#48)) ([9473f89](9473f89)) * contract string ([#82](#82)) ([c062de0](c062de0)) * count for participant was not calculated with ([#89](#89)) ([f511988](f511988)) * DNS-1035 label ([#44](#44)) ([1bf8541](1bf8541)) * erigon perms issue ([#76](#76)) ([0328314](0328314)) * explicitly set client contexts0 ([30017f2](30017f2)) * force offset time to be int ([#64](#64)) ([74b6417](74b6417)) * github action should fail if any jobs fail ([#78](#78)) ([577ca3b](577ca3b)) * grammar in docs ([#33](#33)) ([d6fb36f](d6fb36f)) * handling of config options ([#85](#85)) ([5b085c8](5b085c8)) * image label name too long, truncate at 63 chars ([#90](#90)) ([5bd687c](5bd687c)) * l2 contract deployment ([#35](#35)) ([3f2b16d](3f2b16d)) * Provide default participants ([#77](#77)) ([a7d72da](a7d72da)) * Remove wait for finalization for create2 factory deployment ([#60](#60)) ([d4c37f0](d4c37f0)) * test k8s ([#47](#47)) ([ac17e89](ac17e89)) * trust l1 rpc in op-node ([#41](#41)) ([05dcd2e](05dcd2e)) * Update neth image; improve genesis tool ([#73](#73)) ([71e61c8](71e61c8)) * update op-geth hash based storage ([#61](#61)) ([f0b5b23](f0b5b23)) * Validate root params ([#79](#79)) ([914a808](914a808)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the need to wait for the finalization of the L1 chain before deploying the create2 factory.
TODO
config.shin the OP monorepo'sgetting-starteddir to allow for fetching an L1 block other than thefinalizedtag (context)