Add Chainid to p2p filter #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Jan 26, 2025
|
|
||
| // clear pstore from DB if the version is not match | ||
| // the DB path is set by p2p.peerstore.path flag, and the default value is esnode_peerstore_db | ||
| go func() { |
There was a problem hiding this comment.
What is the purpose of this function, and in what scenarios would we need to increase the p2pversion?
|
Is there a note that outlines what boot node and full node operators should do for the beta testnet if they take this PR? Additionally, should we update our runL2.sh script to include the new ENR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently, we use l1.chain_id to filter ENR in the discovery UDPv5 table, which cannot filter out the es-node ENR that has been connected before. Also, the run*.sh does not set the l1.chain_id, and the es-node will use 1 as the default value.
So now, we only use the contract address as a filter in the SyncClient.AddPeer filters out es-nodes that do not belong to the same network. However, when we change SWC from Alpha to Beta, the contract address will not change. So, Alpha and Beta es-node networks will join together if any Beta es-node does not clear its discovery DB (esnode_discovery_db) before it starts.
How to fix:
Note: After this change, the Bootnode ENR will be changed, so all the es-nodes in the network need to sync to the latest code and restart.
How to test:
withthis chain ID change + es-nodewiththis chain ID change should connect and sync.withthis chain ID change + es-nodewithoutthis chain ID change should not connect and sync.withoutthis chain ID change + es-nodewiththis chain ID change should not connect and sync.switchto this chain ID change without clear esnode_discovery_db and esnode_peerstore_db, es-nodewithoutthis chain ID change should not connect and sync.switchto this chain ID change without clear esnode_discovery_db and esnode_peerstore_db, it shouldconnect to bootnode
withthis chain ID change and it should not connect to bootnodewithoutthis chain ID change.