UpgradeSoulGasToken.s.sol: get admin correctly #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed successfully with the correct owner on |
Fixed in 148cdfc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
soulGasToken.admin()call in thepreCheckwill revert for similar reason as #173, this PR fixes it.Lessons learned are that we need to call
IProxyAdminmethods to callProxymethods, otherwise it'll be dispatched to the implementation contract.(Note the patched
UpgradeSoulGasToken.s.solhas already been applied successfully on beta testnet, so that this PR serves more as knowledge sharing.)