1832 error parent user creation (#1834)

Co-authored-by: Adam Sachs <adam@Adams-MBP.hsd1.ma.comcast.net>

CHANGELOG.md

@@ -18,6 +18,12 @@ The types of changes are:
 
 ## [Unreleased](https://github.com/ethyca/fides/compare/2.1.0...main)
 
+### Added
+* Add authenticated privacy request route. [#1819](https://github.com/ethyca/fides/pull/1819)
+
+### Fixed
+* Fix error in parent user creation seeding. [#1832](https://github.com/ethyca/fides/issues/1832)
+
 ### Docs
 
 * Remove documentation about no-longer used connection string override [#1824](https://github.com/ethyca/fides/pull/1824)
@@ -39,7 +45,6 @@ The types of changes are:
 * Privacy-Center-Cypress workflow for CI checks of the Privacy Center. [#1722](https://github.com/ethyca/fides/pull/1722)
 * Privacy Center `fides-consent.js` script for accessing consent on external pages. [Details](/clients/privacy-center/packages/fides-consent/README.md)
 * Erasure support for Twilio Conversations API [#1673](https://github.com/ethyca/fides/pull/1673)
-* Add authenticated privacy request route. [#1819](https://github.com/ethyca/fides/pull/1819)
 
 ### Changed
 

src/fides/api/ctl/database/seed.py

@@ -78,6 +78,8 @@ def create_or_update_parent_user() -> None:
                 log.info("Updating parent user")
                 user.update_password(db_session, CONFIG.security.parent_server_password)
                 return
+            # clean exit if parent user already exists and credentials match
+            return
 
         log.info("Creating parent user")
         user = FidesUser.create(

src/fides/api/main.py

@@ -219,7 +219,11 @@ async def setup_server() -> None:
 
     await configure_db(CONFIG.database.sync_database_uri)
 
-    create_or_update_parent_user()
+    try:
+        create_or_update_parent_user()
+    except Exception as e:
+        log.error(f"Error creating parent user: {str(e)}")
+        raise FidesError(f"Error creating parent user: {str(e)}")
 
     log.info("Validating SaaS connector templates...")
     try:

tests/ctl/api/test_seed.py

@@ -278,6 +278,28 @@ def test_create_or_update_parent_user(db):
     user.delete(db)
 
 
+@pytest.mark.usefixtures("parent_server_config")
+def test_create_or_update_parent_user_called_twice(db):
+    """
+    Ensure seed method can be called twice with same parent user config,
+    since this is effectively what happens on server restart.
+    """
+    seed.create_or_update_parent_user()
+    user = FidesUser.get_by(
+        db, field="username", value=CONFIG.security.parent_server_username
+    )
+
+    assert user is not None
+
+    seed.create_or_update_parent_user()
+    user = FidesUser.get_by(
+        db, field="username", value=CONFIG.security.parent_server_username
+    )
+
+    assert user is not None
+    user.delete(db)
+
+
 @pytest.mark.usefixtures("parent_server_config")
 def test_create_or_update_parent_user_change_password(db):
     user = FidesUser.create(