Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1832 error parent user creation #1834

Merged
merged 3 commits into from
Nov 21, 2022
Merged

1832 error parent user creation #1834

merged 3 commits into from
Nov 21, 2022

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Nov 21, 2022 •
edited
Loading

Closes #1832

Code Changes

  • handle base case of same parent user credentials on startup
    • add some test coverage around this case
  • make sure errors in parent user creation are at least logged

Steps to Confirm

  • Check issue description

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs marked this pull request as ready for review November 21, 2022 17:17
@adamsachs adamsachs requested a review from sanders41 November 21, 2022 17:17
@sanders41 sanders41 mentioned this pull request Nov 21, 2022
Closed
11 tasks
@adamsachs adamsachs merged commit ba9aad0 into main Nov 21, 2022
@adamsachs adamsachs deleted the 1832-error-parent-user-creation branch November 21, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught error on parent user creation
2 participants
@adamsachs @sanders41