Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a config UI page for AWS scanning #576

Closed
ThomasLaPiana opened this issue May 4, 2022 · 7 comments · Fixed by #812
Closed

Create a config UI page for AWS scanning #576

ThomasLaPiana opened this issue May 4, 2022 · 7 comments · Fixed by #812
Assignees

Comments

@ThomasLaPiana
Copy link
Contributor

ThomasLaPiana commented May 4, 2022

Is your feature request related to a specific problem?

A description of what the problem is.
Ex. I'm always frustrated when [...]

Describe the solution you'd like

Needs to include a form that asks the user for their credentials

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Aha! Link: https://ethyca.aha.io/features/CTL-120

@ssangervasi
Copy link
Contributor

@ThomasLaPiana
Copy link
Contributor Author

@ssangervasi I think Michael slipped that in, @mfbrown can confirm?

@mfbrown
Copy link

mfbrown commented Jun 23, 2022

@ssangervasi Definitely use Figma. Sorry for the confusion with the Aha link. I'll look to see what that was added.

@ssangervasi
Copy link
Contributor

Note for reference - It took me a minute to find the API this uses: "generate" instead of "scan". The CLI uses "scan" for both AWS and Okta.

@SteveDMurphy
Copy link
Contributor

Note for reference - It took me a minute to find the API this uses: "generate" instead of "scan". The CLI uses "scan" for both AWS and Okta.

There was some considerable conversation around the naming in here as part of #642

The current difference is generate will generate the manifest for found infrastructure while scan will compare existing fides manifests against what is found. I don't think we have found a solid path forward yet but discover had been mooted as a possible command at some point as well

@ssangervasi
Copy link
Contributor

I wanted to try out my branch calling the actual API but got hung up on the "obscure string" requirement of the key fields. Here is my attempt to use a zlib compatible package and JS text encoding that is supposed to work. It didn't work. I think the problem on that branch is that btoa won't decode from a byte array, but it also doesn't have a convention for escaping UTF-8 sequences. So we'd need some other dependency for a working base64 encoder... and that encoder has to use the same convention as python's encoder, which is not guaranteed.

@SteveDMurphy you had some 🤔 about how the frontend would obscure strings in your PR, and the answer is 🙀

@SteveDMurphy
Copy link
Contributor

Ya there was a bit of hesitation around how this might play out @ssangervasi!
In the meantime, maybe we can unblock just by disabling the obscure steps in your branch to buy time to work through potential avenues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants