-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[576] ui/config-wizard: Page for aws scanning #812
Merged
ssangervasi
merged 9 commits into
main
from
ssangervasi/576/create-a-config-ui-page-for-aws-scanning
Jun 28, 2022
Merged
[576] ui/config-wizard: Page for aws scanning #812
ssangervasi
merged 9 commits into
main
from
ssangervasi/576/create-a-config-ui-page-for-aws-scanning
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssangervasi
commented
Jun 28, 2022
allisonking
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, nice job! 💯
ssangervasi
changed the title
Ssangervasi/576/create a config UI page for aws scanning
[576] ui/config-wizard: Page for aws scanning
Jun 28, 2022
This package is recommended by Formik and the config wizard will definitely be helped by it.
ssangervasi
force-pushed
the
ssangervasi/576/create-a-config-ui-page-for-aws-scanning
branch
from
June 28, 2022 19:56
5276f9a
to
c462297
Compare
ssangervasi
deleted the
ssangervasi/576/create-a-config-ui-page-for-aws-scanning
branch
June 28, 2022 22:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #576
Code Changes
Steps to Confirm
AWS: fidesctl-integration-test
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This includes the layout of wizard step 2, the form inputs, and some placeholders. I tackled a few other UI elements that were giving me trouble along the way: the buttons and icons I listed above. The PR got a little big, so I can could split some of those commits into a separate PR if we would prefer.
📢 I'm going to open a discussion on our state management for the wizard. E.g. how do we pass the organization key?
📝 The API won't yet work (I can't test it) because of how strings are obscured
Demo:
https://user-images.githubusercontent.com/2236777/176061192-51ee6c18-acd0-48cf-bb9d-1a296833ffca.mp4
📝 I noticed while recording that I didn't make the secret key hide/show so I'll add a commit for that.