Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.0 #2295

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Release 2.5.0 #2295

merged 4 commits into from
Jan 19, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jan 19, 2023

Pre-Release Steps

General

  • Quickstart verified working and up-to-date
  • Add any new tables/columns to the database diagram if they have not already been added
    • To check for the new tables/columns that have been added in the release, look for new migration files in the src/fides/api/ctl/migrations directory and inspect their contents
    • If found, look at the latest database diagram, and check whether it contains the tables/columns that were added in these migrations
    • If the diagram is not up to date, follow the steps in the link above to generate a new database diagram with the up-to-date schema, ensuring that all tables and their relationships can be clearly seen
  • nox -s test_env works (verify the admin UI, privacy center, CLI and webserver)
  • nox -s "build(sample)" works on the release branch, creating the sample images (this is also prereq for fides deploy up)
  • fides deploy up --no-pull works using the images built in previous step (verify the admin UI, privacy center, CLI and webserver)
mkdir ~/fides-2-1-0-test
cd ~/fides-2-1-0-test
python3 -m venv venv
source venv/bin/activate
pip install git+https://github.com/ethyca/fides.git@<branch>
fides deploy up --no-pull
fides status
fides deploy down
rm -rf ~/fides-2-1-0-test
exit 

Next, run the following checks against the environment you've spun up using fides deploy up --no-pull:

API

  • Verify that the generated API docs are correct
  • Verify that the Postman collection has been updated

CLI

Run these from within nox -s dev -- shell

  • Run a fides push
  • Run a fides pull
  • Run a fides evaluate
  • Generate a dataset with fides generate dataset db --credentials-id app_postgres test.yml
  • Scan a database with fides scan dataset db --credentials-id app_postgres

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

Post-Release Steps

@SteveDMurphy SteveDMurphy marked this pull request as ready for review January 19, 2023 20:56
@SteveDMurphy
Copy link
Contributor Author

@NevilleS - can we confirm if there should be a latest tag for the fides-privacy-center? It looks like it hasn't been updated in a few months and no similar tag exists for fides-sample-app

@SteveDMurphy SteveDMurphy requested a review from NevilleS January 19, 2023 21:15
@NevilleS
Copy link
Contributor

Thanks @SteveDMurphy - I'd actually prefer we publish :latest for all our images:

  • fides
  • fides-privacy-center
  • fides-sample-app

It's a known issue that we weren't publishing latest but I don't think we ticketed it - whoops.

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SteveDMurphy
Copy link
Contributor Author

latest pushed manually for both and #2301 opened - thanks!

@SteveDMurphy SteveDMurphy merged commit ec77b62 into main Jan 19, 2023
@SteveDMurphy SteveDMurphy deleted the release-2.5.0 branch January 19, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants