Release 2.5.0

clients/admin-ui/cypress/README.md

@@ -12,7 +12,7 @@ npm run start
 npm run cy:open
 ```
 
-However, because we do some [inter-zone navigation](https://github.com/ethyca/fides/blob/main/clients/admin-ui/src/features/common/zones/config.ts/#L12-L24) which Cypress will not handle due to security risks, sometimes it is important to run the webapp with `NODE_ENV=test`. We have a command `cy:start` which captures that, and also makes the server a little faster via a production build.
+However, because we do some [inter-zone navigation](https://github.com/ethyca/fides/blob/main/clients/admin-ui/src/features/common/zones/config.ts/#L12-L24) which Cypress will not handle due to security risks, sometimes it is important to run the webapp with `NODE_ENV=test`. We have a command `cy:start` which captures that, and also makes the server a little faster via a production build. This will potentially cause issues if testing manually with `fidesplus`, however the Cypress tests will run properly.
 
 ```
 # Start the webapp in test mode

docs/fides/docs/development/release_checklist.md

@@ -10,9 +10,10 @@ This checklist should be copy/pasted into the final pre-release PR, and checked
 
 - [ ] Quickstart verified working and up-to-date
 - [ ] Add any new tables/columns to the [database diagram](https://github.com/ethyca/fides/blob/5a485387d8af247ec6479e4115088cbbb8394d77/docs/fides/docs/development/update_erd_diagram.md) if they have not already been added
-    - To check for the new tables/columns that have been added in the release, look for new migration files in the `src/fides/api/ctl/migrations` directory and inspect their contents
-    - If found, look at the latest database diagram, and check whether it contains the tables/columns that were added in these migrations
-    - If the diagram is not up to date, follow the steps in the link above to generate a new database diagram with the up-to-date schema, ensuring that all tables and their relationships can be clearly seen
+  - To check for the new tables/columns that have been added in the release, look for new migration files in the `src/fides/api/ctl/migrations` directory and inspect their contents
+  - If found, look at the latest database diagram, and check whether it contains the tables/columns that were added in these migrations
+  - If the diagram is not up to date, follow the steps in the link above to generate a new database diagram with the up-to-date schema, ensuring that all tables and their relationships can be clearly seen
+  - Open up an issue on [fidesdocs](https://github.com/ethyca/fidesdocs/issues) to update the diagram on the new docs site
 - [ ] `nox -s test_env` works (verify the admin UI, privacy center, CLI and webserver)
 - [ ] `nox -s "build(sample)"` works on the release branch, creating the sample images (this is also prereq for `fides deploy up`)
 - [ ] `fides deploy up --no-pull` works using the images built in previous step (verify the admin UI, privacy center, CLI and webserver)
@@ -27,7 +28,7 @@ fides deploy up --no-pull
 fides status
 fides deploy down
 rm -rf ~/fides-2-1-0-test
-exit 
+exit
 ```
 
 Next, run the following checks against the environment you've spun up using `fides deploy up --no-pull`:

scripts/quickstart.py

@@ -324,7 +324,7 @@ def create_dsr_policy(key: str):
     if response.ok:
         policies = (response.json())["succeeded"]
         if len(policies) > 0:
-            logger.info("Created fidesops policy with key=%s via {url}", key)
+            logger.info("Created fidesops policy with key={key} via {url}")
             return response.json()
 
     raise RuntimeError(