Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow masking without primary keys #5575

Draft
wants to merge 25 commits into
base: split-query-config-files
Choose a base branch
from
Draft

Allow masking without primary keys #5575

wants to merge 25 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 9, 2024 •
edited by jira bot
Loading

Closes LA-95

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 9:56pm

@cypress Cypress
Copy link

cypress bot commented Dec 9, 2024 •
edited
Loading

fides    Run #11615

Run Properties:  status check passed Passed #11615  •  git commit 12d859802b ℹ️: Merge 74f6b22b6dee4a460a282e6e255874fab7507e6d into 12ce3d661ddd8d835be7fa8f36a6...
Project fides
Branch Review refs/pull/5575/merge
Run status status check passed Passed #11615
Run duration 00m 37s
Commit git commit 12d859802b ℹ️: Merge 74f6b22b6dee4a460a282e6e255874fab7507e6d into 12ce3d661ddd8d835be7fa8f36a6...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Dec 10, 2024
@galvana galvana changed the base branch from main to split-query-config-files December 10, 2024 22:25
@galvana galvana mentioned this pull request Dec 19, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galvana