Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting up query config files and tests #5591

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Splitting up query config files and tests #5591

wants to merge 2 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 10, 2024 •
edited
Loading

Description Of Changes

This change is done as part of #5575. I broke it out into a separate PR so it's easier to see the changes done to the query config files.

Code Changes

  • Splitting out different query configs into their own files

Steps to Confirm

  1. Tests should pass, this doesn't change any functionality

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 9:52pm

@cypress Cypress
Copy link

cypress bot commented Dec 10, 2024 •
edited
Loading

fides    Run #11614

Run Properties:  status check passed Passed #11614  •  git commit f54d594522 ℹ️: Merge 12ce3d661ddd8d835be7fa8f36a67ab94264990b into 185ad7e59b9cc26eef93c9703711...
Project fides
Branch Review refs/pull/5591/merge
Run status status check passed Passed #11614
Run duration 00m 48s
Commit git commit f54d594522 ℹ️: Merge 12ce3d661ddd8d835be7fa8f36a67ab94264990b into 185ad7e59b9cc26eef93c9703711...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana marked this pull request as ready for review December 19, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind Awaiting requested review from eastandwestwind

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galvana