Feature/multithreading #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpantic
previously approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Very nice!!
See comments, a few nitpicks.
One comment about the is_running bool - that one I would rename to "thread_exit_requested" and invert the logic, as the is_running property is ambigious due to the fact that the thread also can be asked if its running. otherwise great!
|
btw I think the assignement and retrieval operators of atomics are overloaded, so no need to call load/store explicitely. On the other hand it also somehow documents that these are atomics, so whatever you prefer 🤷♂️ :-) See https://en.cppreference.com/w/cpp/atomic/atomic/operator%3D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a simple thread for each receiver after opening the device. The thread reads and processes the SBP message from the device sequentially. It is joined on destruction of the object.
Allows opening multiple devices in the ROS node in parallel. Here we have two receivers outputting the heartbeat message.
See also #102