Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ros relays #117

Merged
merged 27 commits into from
Oct 23, 2019
Merged

Feature/ros relays #117

merged 27 commits into from
Oct 23, 2019

Conversation

rikba
Copy link
Collaborator

@rikba rikba commented Oct 20, 2019 •
edited
Loading

This PR introduces relays for useful ROS messages.

  • ROS time handler that can convert GPS times to ROS UTC times
  • IMU scaling
  • Various position messages
  • Receiver state message

To be merged after #112
Adresses #102

image

rikba added 22 commits October 18, 2019 00:14
@rikba
Implement time buffer and prepare ROS relays.
5257be7
@rikba
Implement first ROS relay.
1535bf7
@rikba
Remove callback on deconstruction.
01d7393
@rikba
Create ROS relays.
75fa2d9
@rikba
Refactor folder structure.
fd73d2c
@rikba
Implement some ros functions.
e840255
@rikba
Merge branch 'master' into feature/ros_relays
e34f05a
@rikba
Merge branch 'feature/observations' into feature/ros_relays
8f0a180
@rikba
Create UTC time buffer when creating object.
96d56eb
@rikba
Only buffer a single value.
433b82e
@rikba
Implement ROS time handler.
2bf77a4
@rikba
Remove time buffer.
d7db6f5
@rikba
Implement IMU relay.
7c62240
@rikba
Mag relay.
7c30af1
@rikba
Ros message flag handling and publishing on demand.
aedaa79
@rikba
Fix external event stamp.
5cbf318
@rikba
Better runtime order.
59d12ca
@rikba
Update receiver state to include utc time.
64c6f4b
@rikba
Handle error logging and expose state.
88e0d23
@rikba
Publish ros receiver state.
6270b4a
@rikba
Typedef receiver state msg.
3e20358
@rikba
Complete navsat fix message.
c465d22
@rikba rikba requested a review from michaelpantic October 20, 2019 11:37
@michaelpantic
Copy link
Member

@rikba merged the other PR, can you merge new master into this branch?

@rikba
Copy link
Collaborator Author

rikba commented Oct 21, 2019

Merged master @michaelpantic Ready to review.

michaelpantic
michaelpantic previously approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@michaelpantic michaelpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! a few nits (see comments)

piksi_multi_cpp/src/sbp_callback_handler/sbp_callback_handler_relay/ros_receiver_state.cc Outdated Show resolved Hide resolved
piksi_multi_cpp/src/sbp_callback_handler/sbp_callback_handler_relay/ros_time_handler.cc Show resolved Hide resolved
piksi_multi_cpp/src/sbp_callback_handler/sbp_callback_handler_relay/ros_time_handler.cc Show resolved Hide resolved
@rikba rikba merged commit 414bddf into master Oct 23, 2019
@rikba rikba deleted the feature/ros_relays branch October 23, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpantic michaelpantic michaelpantic left review comments

@marco-tranzatto marco-tranzatto Awaiting requested review from marco-tranzatto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikba @michaelpantic