Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #74

wants to merge 1 commit into from

Conversation

bkakilli
Copy link

@bkakilli bkakilli commented Apr 2, 2018

Fix in the readme for possible missing system packages (eigen, flann) and several required ros packages.

@rdube
Copy link
Contributor

rdube commented Apr 3, 2018

@bkakilli thanks for your contribution! Are you sure that all these packages are required? Eg. why ros-kinetic-interactive-markers? Also I would assume that some such as ros-kinetic-tf comes with the default ros install.

Please allow me to leave this PR open until we release the new version (easier not to forget about this when we overwrite).

@bkakilli
Copy link
Author

bkakilli commented Apr 3, 2018

Hi @rdube . I specifically don't know where all these packages are used in the code but I installed segmatch onto our desktop and Jetson TX2 (ubuntu 16.04) and in both systems the catkin build process failed until I install those packages.

Also I would assume that some such as ros-kinetic-tf comes with the default ros install.

It must be true for full-ros install, but I had installed ros-kinetic-ros-base, which probably does not carry those robot related packages. A clause such as "desktop or full version of ros is recommended/required" may be enough in your new release, not to create confusion.

@rdube
Copy link
Contributor

rdube commented Apr 3, 2018

Great thanks for the input!

@rdube rdube closed this Oct 10, 2018
@rdube rdube reopened this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants