Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

78 matselect icon not vertically aligned issue is fixed #159

Conversation

raghavenc5
Copy link
Contributor

Fixes #78 .

Changes proposed in this Pull Request:

  • Clean overriding class to fix this issue

Screenshots / Screen Recording (if applicable)

image

To Test:

  • yarn test

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Mar 16, 2023
@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Mar 17, 2023

Looks like we need pixel perfect @huayunh to verify this. Between dev branch and this PR I really don't see the issue or the adjustment here. This is what I see.

image

  • Not part of this PR but noticed other issues in the outlined and filled mat-selects as well. (icon moving upward)

image

notice the select icon moving upwards

image

Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Jeff you are observing the correct thing. The arrows should NOT move up
image

Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard select looks good before and after select
image
image

@JeffGreiner-eaton
Copy link
Collaborator

I didn't see an open issue for the other configurations on outlined or filled. So logged issue here #161

@huayunh
Copy link
Contributor

huayunh commented Mar 20, 2023

The original issue was not logged for any particular text field variant. I expect all three variants — standard ("underlined"), outlined, and filled — to be fixed, such that the dropdown arrow is vertically centered within the text field boundary, by the end of this PR.

@JeffGreiner-eaton JeffGreiner-eaton self-requested a review March 20, 2023 16:29
@JeffGreiner-eaton
Copy link
Collaborator

The original issue was not logged for any particular text field variant. I expect all three variants — standard ("underlined"), outlined, and filled — to be fixed, such that the dropdown arrow is vertically centered within the text field boundary, by the end of this PR.

@raghavenc5

@raghavenc5
Copy link
Contributor Author

@JeffGreiner-eaton @huayunh I have tested the 'select' outlined, filled variant and got the below images as results. Kindly hard refresh the pages to test again or we can discuss it in the call to clarify this.

Screenshot-2 (1)
Screenshot-1 (1)

@raghavenc5 raghavenc5 requested review from huayunh and JeffGreiner-eaton and removed request for daileytj, JeffGreiner-eaton and huayunh March 23, 2023 10:08
@JeffGreiner-eaton
Copy link
Collaborator

looks good just the conflict, change log

@raghavenc5
Copy link
Contributor Author

@JeffGreiner-eaton Conflict resolved

@JeffGreiner-eaton JeffGreiner-eaton merged commit b8efe79 into etn-ccis:dev Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

<mat-select> icon not vertically aligned
3 participants