-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
78 matselect icon not vertically aligned issue is fixed #159
78 matselect icon not vertically aligned issue is fixed #159
Conversation
Looks like we need pixel perfect @huayunh to verify this. Between dev branch and this PR I really don't see the issue or the adjustment here. This is what I see.
notice the select icon moving upwards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see an open issue for the other configurations on outlined or filled. So logged issue here #161 |
The original issue was not logged for any particular text field variant. I expect all three variants — standard ("underlined"), outlined, and filled — to be fixed, such that the dropdown arrow is vertically centered within the text field boundary, by the end of this PR. |
|
@JeffGreiner-eaton @huayunh I have tested the 'select' outlined, filled variant and got the below images as results. Kindly hard refresh the pages to test again or we can discuss it in the call to clarify this. |
looks good just the conflict, change log |
@JeffGreiner-eaton Conflict resolved |
Fixes #78 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?