Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary workaround for gfx-replay scaling. #3

Closed
wants to merge 1 commit into from
Closed

Temporary workaround for gfx-replay scaling. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Assets/Scripts/GfxReplayPlayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,13 @@ public void ProcessKeyframe(KeyframeData keyframe)

GameObject instance = Instantiate(prefab);

// HACK: Gfx-replay scale is currently invalid. We're ignoring it until the issue is resolved.
/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this on the recording side (in habitat-sim), so no need for this on the player side.

if (creationItem.creation.scale != null)
{
instance.transform.localScale = new Vector3(creationItem.creation.scale[0], creationItem.creation.scale[1], creationItem.creation.scale[2]);
}
*/

instance = HandleFrame(instance, load.frame);

Expand Down