Some cleanups #47
Merged
Some cleanups #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This produces a better visual impression (i.e. an info-box) in the generated book.
%pylab inline is deprecated and should not be used anymore. This commit also introduces the use of matplotlib style sheets in stead of individual plot styling, both to reduce the need for additional imports (i.e. import matplotlib as mpl) and to harmonize the appearence of plots thoughout the book.
Otherwise their caption is hard to find within the text and also the table of contents would not work.
That way, the different spike behaviour should be simpler to interpret visually.
In some places, data was loaded before subsetting which is generally less efficient.
Using `.T` implicitly makes an assumption about the order of dimensions in the source dataset. By changing this to `.transpose` we can explicitly note out intended outcome, which makes the scripts more reliable.
tmieslinger
reviewed
Apr 28, 2021
Merged
Co-authored-by: Theresa Mieslinger <41184617+tmieslinger@users.noreply.github.com>
Co-authored-by: Theresa Mieslinger <41184617+tmieslinger@users.noreply.github.com>
Note: the bibtex entry needs to be updated, once the paper has been submitted / accepted etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several individual commits which are intended to clean up the currently existing notebooks a bit. Some things which are included are:
%pylab inlineis deprecated and should not be used. It is quite likely that I introduced this silly piece of code, I think it is time to get rid of it :-)/how_to_eurec4a/mplstyle. That way, plots should get a more common appearance. I'd suggest to update styles in these files as long as anyhow possible. Currently there are two files, thebookwhich contains basic styles for all plots andwidewhich contains a wider figure aspect ratio which can occasionally be useful.PositionAttitudedata instead of BAHAMASQLdataload()to speed things up. (in general, one doesn't want to call this function)