-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add P3 examples #52
Add P3 examples #52
Conversation
…building on Github to use conda
To install Python dependencies with conda: |
... and probably we need to update |
@tmieslinger In case you have the bandwidth to look over these changes (@d70-t being quite busy it seems), I would prefer not to merge them until someone else had a look at them. Note that the cell timeout is currently set to 150 seconds; this sometimes is too short for the P-3 flight track cells. Also - we're now using |
Sorry for not responding yet. I generally like the changes a lot, but had to do something else the last two days. I've got a few comments and will likely post a partial review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @RobertPincus,
thank you very much for all these new book chapters. I think they are really valuable and nicely made! 👍 In particular I like how you describe all the things, that is exactly what we need.
I've quite a few technical comments to the code. I've split those up into individual suggestions and comments such that we could discuss about them. I hope they are consistent, but probably I've missed something.
I only had a deeper look at the AXBTs for now, but from quickly looking over the others, I think that some of those suggestions will apply to others as well.
I'll leave this review as is for now and have a look at some other open things for a moment.
Apart from those, we'll need:
- an update in the "running locally" chapter which describes how to set up the conda based environment. As I also don't want to force others to install conda only to build the book, there should still be an option to install via pip. I think it is ok to state that if someone wants to use pip, one needs to take care of the cartopy installation requirements beforehand and put a link to their documentation.
- we should have another CI job which ensures that installing via pip still works.
how_to_eurec4a/p3_AXBTs.md
Outdated
import eurec4a | ||
cat = eurec4a.get_intake_catalog() | ||
``` | ||
Mapping takes quite some setup. Maybe this should become part of the `eurec4a` Python module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. However I am yet undecided if the eurec4a
module should grow larger than accessing EUREC4A data and metadata. I think functions like those should either be in a generic campaign data analysis package or we should make chapters of the book importable (#28).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the best way forward. All the mapping stuff in my contributions comes from Bjorn in any case. It does seem strange to have to repeat code in every document independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to go towards importable book chapters, but I am afraid that I won't be able to do that right now... Thus for now, we probably need to stick a little with repeated code.
@d70-t Cool, thanks, I'll take a look. The book chapters are just excerpts from the notebook that generates figures for the paper, which is why there's overlap... |
@d70-t How should we proceed with |
Initially I thought the best solution might be to include But now I am thinking, maybe it is actually better not to specify it in If a user who doesn't use conda is more in the I'd suggest to update the |
@d70-t I added material to the chapter on running locally to describe the use of |
As @tmieslinger noted, it seems like I've forgotten to include the def color_of_day(day):
return plt.cm.viridis(norm(day), alpha=0.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertPincus thank you so much for this nice contribution to the book! I had great fun reading the Ms Piggy chapters :-) they are easy to follow and are a nice complement to the P3 data paper.
I have some really minor comments on top of @d70-t's. Currently, I favor the idea of having a separate domain name for the book and linking that to GitHub pages as discussed in the issue #53 . As far as I understand we could then get rid of the GitLab integration, which means that we don't have to adjust the GitLab workflow to the new conda setup. In the GitHub workflow we should ideally include another job for building the book with pip only. And finally, we could merge this PR while being on the save side that the book compiles and people understand the conda/pip difference? Did I understand that correctly?
Seems like a long detour that would however really improve the book :)
Updating to current master
AXBT deployments, etc. Thanks to @d-70t.
@d70-t @tmieslinger Thanks for your very helpful comments. I believe they are all incorporated including a little bit of extra explanation about how to run locally. I've explained that users need to manage the installation of I have not updated the gitlab-ci to work with conda so the book won't publish automatically until/unless you adopt the Github publishing @d70-t is working on with #53 . As of now I won't plan to make further changes until the publishing issue is resolved, but it would be nice to have this folded in sooner than later. |
I would suggest that you add yourselves as co-authors to the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RobertPincus for all those updates. I've now also reviewed the other notebooks as well. I've got one major speedup and a few more nitpicks for you. Otherwise, I think we only have to wait for the DNS entry for howto.eurec4a.eu
to become live (I already asked for it, but am still waiting for an answer) and then we are all set for a merge. 🎉
how_to_eurec4a/p3_AXBTs.md
Outdated
import eurec4a | ||
cat = eurec4a.get_intake_catalog() | ||
``` | ||
Mapping takes quite some setup. Maybe this should become part of the `eurec4a` Python module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to go towards importable book chapters, but I am afraid that I won't be able to do that right now... Thus for now, we probably need to stick a little with repeated code.
@d70-t The speedup was an excellent suggestion, thanks a lot, and I think all the changes are in place. The CI is failing in the HAMP chapter for reasons I don't understand, but we can re-run the CI before merging once the domain is in place. |
The HAMP files have been moved. That should be fixed in eurec4a/eurec4a-intake#67, but maybe I'll have to add another quick fix to the book as the version update could lead to a minor issue in some of the chapters... I'll sort it out. |
@d70-t @tmieslinger I brought the P-3 pull request up to date with the excellent changes on master. I hesitate to squash-and-merge because I don't understand what will happen to the Gitlab CI, which uses pip without cartopy, while the Github CI and publication uses conda |
Adds a few hopefully interesting examples focusing on measurements from the P-3. Uses the
colorcet
,seaborn
and especiallycartopy
Python modules.Cartopy
has many dependencies so modules are now installed viaconda
for the Continuous Integration. Addingcartopy
closes #50 and may be relevant to #11.Probably best to squash-and-merge as no one needs to see my stumbling around.