Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to go modules and simplify package structure #57

Closed
wants to merge 2 commits into from
Closed

Convert to go modules and simplify package structure #57

wants to merge 2 commits into from

Conversation

jschaf
Copy link
Contributor

@jschaf jschaf commented Apr 12, 2020

There's two commits here. The first uses go modules instead of GOPATH. The second commit simplifies the package structure to use pkg for library code and cmd for binaries.

Working

  • make esbuild succeeds and rebuilds for changes in pkg/* and cmd/*.
  • make test succeeds.
  • make update-version-go succeeds and updates the verison.
  • make platform-all succeeds.
  • make clean succeeds.
  • make demo-three succeeds.
  • make bench-three succeeds.

Not working

  • make test262 hangs.

@jschaf
Copy link
Contributor Author

jschaf commented Apr 12, 2020

Oh, I missed your intent from the other PRs (#9) I'll close.

@jschaf jschaf closed this Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant