Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go.mod for esbuild in go 1.13 #9

Merged
merged 1 commit into from
Apr 16, 2020
Merged

add go.mod for esbuild in go 1.13 #9

merged 1 commit into from
Apr 16, 2020

Conversation

awkj
Copy link
Contributor

@awkj awkj commented Feb 16, 2020

No description provided.

@NaLLiFFuNT
Copy link

@evanw Hi, your project is great! Could you add go mod support so that it would be easier contributing your project?

@evanw
Copy link
Owner

evanw commented Feb 17, 2020

This is a personal side project and I'm not looking for contributions at this time. Currently esbuild doesn't have any dependencies and I'd like to keep it that way if I can. I'm also not intending for the Go source code in this repo to be imported as a library into other projects. See #13 (comment) for my rationale.

@tooolbox
Copy link
Contributor

@awkj I'm not sure how this helps. I guess with that file in place, you can do cd src/esbuild && go build -o esbuild ./main/* ? You can't go get it AFAICT.

@evanw
Copy link
Owner

evanw commented Apr 16, 2020

I'm going to try merging this to fix #63 (people having build problems because of a global GO111MODULE=on environment variable override).

@evanw evanw merged commit ab95488 into evanw:master Apr 16, 2020
@brandly brandly mentioned this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants