[WIP] Add PHP 8 support and configuration by attributes #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #2
This adds support for the following:
EventEngine\Discolight\ServiceDefinition
).callable
)Above list is available for PHP 8 only but doesn't break applications running PHP 7.
Example 1:
Example 2:
Fixed some unreachable code as well. The null check in the following code can not happen:
Oh, and I've removed the prooph/php-cs-fixer-config dependency for now, since it's not PHP 8 ready yet.