Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8 #8

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Support PHP 8 #8

merged 1 commit into from
Dec 21, 2020

Conversation

sandrokeil
Copy link
Member

@sandrokeil sandrokeil commented Dec 11, 2020

php-cs-fixer binary is not ready yet for PHP 8 but php-cs-fixer can be run < PHP 8.0. So it's ready to merge.

@sandrokeil sandrokeil changed the title Support PHP 8 [WIP] Support PHP 8 Dec 11, 2020
@sandrokeil sandrokeil changed the title [WIP] Support PHP 8 Support PHP 8 Dec 16, 2020
@sandrokeil
Copy link
Member Author

sandrokeil commented Dec 16, 2020

@prolic @codeliner I think it can be merged now. I don’t have the access rights to do this and to create a new release.

@prolic
Copy link
Member

prolic commented Dec 16, 2020

@sandrokeil there seems to be a problem, see travis results:

$ ./vendor/bin/php-cs-fixer fix -v --diff --dry-run

PHP needs to be a minimum version of PHP 5.6.0 and maximum version of PHP 7.4.*.

The command "./vendor/bin/php-cs-fixer fix -v --diff --dry-run" exited with 1.

@prolic prolic self-assigned this Dec 16, 2020
@prolic
Copy link
Member

prolic commented Dec 16, 2020

@sandrokeil as PHP 8 installation is possible with php-cs-fixer, but it's not possible to run it as of now, we can just skip php-cs-fixer for PHP 8 runs on travis. This should do the trick so we can get this pushed forward.

@sandrokeil
Copy link
Member Author

@prolic I fixed it. (Travis is so slow)

@prolic prolic merged commit 71b386b into prooph:master Dec 21, 2020
@prolic
Copy link
Member

prolic commented Dec 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants