Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPRESSO_TXN_PAGE shortcode #2

Closed
dgilfoy opened this issue Jan 18, 2013 · 13 comments
Closed

ESPRESSO_TXN_PAGE shortcode #2

dgilfoy opened this issue Jan 18, 2013 · 13 comments

Comments

@dgilfoy
Copy link

dgilfoy commented Jan 18, 2013

Not sure if this is an issue or is a known issue but the ESPRESSO_TXN_PAGE shortcode on the transaction page isn't working and I don't see a corresponding function in the shortcodes.php file.

Are you phasing out the page itself or something similar?

@jazzsequence
Copy link

Not phasing it out. That page is required to receive the IPN from gateways. In what way is it not working?

@dgilfoy
Copy link
Author

dgilfoy commented Jan 18, 2013

The page is just displaying [ESPRESSO_TXN_PAGE] in the content rather than outputting anything. I just checked and found it in the gateways/process_payments.php file, not sure why it isn't working on my install.

@jazzsequence
Copy link

That's odd. Have you already tried switching to TwentyTen and disabling your other plugins? It's certainly not a known issue. What version are you seeing this on?

@dgilfoy
Copy link
Author

dgilfoy commented Jan 18, 2013

WordPress 3.5 and TwentyTwelve. I just synced my install with the latest development branch yesterday.

I had the issue before though too.

@jazzsequence
Copy link

Dev branch may well be broken. Beta branch is most stable.

@jazzsequence
Copy link

We did a lot of fixes that we're still working through that changed how the shortcodes were handled for the Jetpack issues people were having, and we're still going through testing on a lot of that stuff (on Beta).

@nerrad
Copy link
Contributor

nerrad commented Jan 18, 2013

chris, daniels comments here apply to Event Espresso 3.2 not 3.1 (see the repo referenced above).

Daniel, 3.2 is currently in alot of flux and master branch is quite a bit of commits behind development. You'll want to raise issues you see on the development branch until we get to the beta release (and a specific branch will be created for that).

At some point we're going to update the readme.md file with our development workflow (and a corresponding blog post) but hopefully that will point you in the right direction. Also any branches prefixed "FET" are things that are being worked on as well.

@jazzsequence
Copy link

@nerrad You're right. I saw event-espresso-core and was thinking the OTHER event espresso core :)

@dgilfoy
Copy link
Author

dgilfoy commented Jan 18, 2013

Thanks nerrad, I selected the development branch and then hit issues thinking that would put this in the right place, but I guess not.

I ended up resolving the issue for myself. If I move the
add_shortcode('ESPRESSO_TXN_PAGE', 'return_espresso_content');

function call before the ob_start() call (within the event_espresso_txn function in process_payments.php) , the shortcode works but after the $espresso_content = ob_get_clean(); assignment it fails. Not entirely sure why.

@nerrad
Copy link
Contributor

nerrad commented Jan 18, 2013

Thanks for reporting this daniel. This is one of the reasons why we created this github repo so we can get feedback from developers as we develop :)

Feel free to submit a pull request and if its something that works (and we haven't already fixed it elsewhere) we'll add it in :)

@nerrad
Copy link
Contributor

nerrad commented Jan 18, 2013

@tn3rb pulling you into this, you've done a number of changes with the shortcodes stuff - is this something already fixed?

@tn3rb
Copy link
Member

tn3rb commented Jan 18, 2013

Out put buffering would have no affect on shortcode parsing since it basically just prevents headers being sent by sending the output to a buffer instead of returning it to the user. All other functionality (like shortcodes) still proceeds normally.

That said, yes this is fixed (or should be) but make sure your development branch has had the FET-1939-refactor-shortcodes branch merged into it. If it has, then something else might be out of whack. Here's some things to check:

Go to the Page Settings section of the Espresso General Settings page ( wp-admin/admin.php?page=event_espresso ) and check to see that everything is set ok for your Transactions page. Is that the page you have been visiting? The [ESPRESSO_TXN_PAGE] shortcode will not work on any other page now. Try updating your settings even if things look ok.

If everything looks ok there, then check the Page settings themselves (wp-admin/post.php?post=##&action=edit), and make sure everything looks ok there, although I can't even think of how a setting here could muck up the shortcode.

If all else fails, de-re-activate the plugin, while having a word with the supreme being of your choice, and try it again.

Let us know how things go, and if the problem persists, and this is happening on a web accessible server, then plz let me take a look so I can figure this out for you.

Thnx

@dgilfoy
Copy link
Author

dgilfoy commented Jan 21, 2013

Thanks tn3rb! I'll go ahead and close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants