Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3104-3105-3106-3107 feature/vertical sidebar, projects, favorites and role based navigation in sidebar #3199
3104-3105-3106-3107 feature/vertical sidebar, projects, favorites and role based navigation in sidebar #3199
Changes from all commits
7a008fa
76c66aa
8d4e354
8d20568
549afa9
7315c05
964121d
13abd85
b511210
e00156b
5bbafd5
8d903ac
13c4d13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider optimizing array operations in toggleFavorite.
While the current implementation is correct, we can optimize the array operations by avoiding multiple array traversals.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing dependency to useCallback in addFavorite.
The
addFavorite
function usesisFavorite
but doesn't include it in the dependency array of useCallback. This could lead to stale closure issues.📝 Committable suggestion