This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-5665 Update cypress e2e task to not report to cypress cloud #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minnakt
approved these changes
Mar 19, 2024
| yarn cy:run --record --key "${parsley_cypress_record_key}" --reporter junit | ||
| # Allow spec filtering for an intentional patch. | ||
| if [[ "${requester}" == "patch" ]]; then | ||
| yarn cy:run --reporter junit --spec "${cypress_spec}" |
There was a problem hiding this comment.
i think this already works without it, but should we add the parameters block like we have in spruce? I'm not really sure what benefit the block gives though 😅
There was a problem hiding this comment.
Sure just added it for consistency!
I was kind of curious about what it did too since I didn't see it in the docs.
I think it does 2 things; applies default values for patch params that are loaded in as expansions and also provides a description when using the evergreen list command in the cli.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-5665
Description
irt the slack thread we will no longer be sending data to cypress cloud.
Testing
The associated task still displays all of the necessary logs and links to files in the files tab