Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-5665 Update cypress e2e task to not report to cypress cloud #515

Merged
merged 4 commits into from
Mar 20, 2024
Merged

DEVPROD-5665 Update cypress e2e task to not report to cypress cloud #515

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9ca933
Update cypress e2e task to not report to cypress cloud
khelif96 Mar 18, 2024
d8b74d4
Allow spec filtering for e2e task
khelif96 Mar 18, 2024
ef82537
Add Cypress spec files parameter to .evergreen.yml
khelif96 Mar 19, 2024
727b850
Types
khelif96 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,14 @@ functions:
shell: bash
script: |
${PREPARE_SHELL}
# Only record to cypress cloud if this is a pr or a mainline commit.
if [[ "${requester}" == "github_pr" || "${requester}" == "commit" || "$requester" == "patch" ]]; then
yarn cy:run --record --key "${parsley_cypress_record_key}" --reporter junit
# Allow spec filtering for an intentional patch.
if [[ "${requester}" == "patch" ]]; then
yarn cy:run --reporter junit --spec "${cypress_spec}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this already works without it, but should we add the parameters block like we have in spruce? I'm not really sure what benefit the block gives though 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure just added it for consistency!
I was kind of curious about what it did too since I didn't see it in the docs.
I think it does 2 things; applies default values for patch params that are loaded in as expansions and also provides a description when using the evergreen list command in the cli.

else
yarn cy:run --reporter junit
fi


yarn-eslint:
command: shell.exec
params:
Expand Down
Loading