Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #2628

Draft
wants to merge 332 commits into
base: next
Choose a base branch
from
Draft

Themes #2628

wants to merge 332 commits into from

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Oct 8, 2024

Description

Checklist

  • I have added a changeset
  • I have added to the docs where applicable
    - I have added to the VS Code extension where applicable
    - For UI or styling changes, I have added a screenshot or gif showing before & after
    Too many changes to screenshot, open the docs/example-project/test-env to check out the theming!

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: d9398d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@evidence-dev/evidence Patch
@evidence-dev/core-components Patch
@evidence-dev/tailwind Patch
@evidence-dev/component-utilities Patch
@evidence-dev/sdk Patch
my-evidence-project Patch
e2e-prerender Patch
e2e-spa Patch
e2e-themes Patch
evidence-test-environment Patch
@evidence-dev/components Patch
@evidence-dev/plugin-connector Patch
@evidence-dev/universal-sql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:51pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:51pm

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for evidence-development-workspace failed. Why did it fail? →

Name Link
🔨 Latest commit 25df5f1
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/672a3e1b534c5d0008ca8225

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit 25df5f1
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/672a3e1b8959590008c236e6
😎 Deploy Preview https://deploy-preview-2628--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 25df5f1
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/672a3e1b9798ed0008c1c33e
😎 Deploy Preview https://deploy-preview-2628--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@archiewood
Copy link
Member

archiewood commented Oct 8, 2024

Overall coming on great

Components

  • Alerts: Note that if you use markdown inside an alert, it colours the text p.markdown colours.

    <Alert status=info>
    
    ## Heading
    
    Para
    
    </Alert>
    

    This means that any colours you set will be ignored. There is some rationale to therefore use the same colours for the text in all of the alerts.

  • Deltas seem a bit bright in Light mode, they were more muted before

    • Same for BigValue green text
    • Same for DataTable deltas
  • DataTable redNegatives are too dark in dark mode

@mcrascal
Copy link
Member

mcrascal commented Oct 9, 2024

I find the “up” green in the big value comparison and elsewhere too light in the light mode.

I find the various alert statuses not quite right in dark mode — I think it’d be worth exploring some transparency on their backgrounds in dark.

@archiewood
Copy link
Member

@mcrascal FYI the screenshots are outdated, both of those have since been adjusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants