Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] Use color names in props #2776

Merged
merged 57 commits into from
Nov 19, 2024

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Nov 13, 2024

Description

Enables the usage of color/colorPalette/colorScale names in props

E.g.

<Story name="Using color token">
	<Tabs color="accent">
		<Tab label="Tab 1" id="tab1">Tab 1 content</Tab>
		<Tab label="Tab 2" id="tab2">Tab 2 content</Tab>
		<Tab label="Tab 3" id="tab3">Tab 3 content</Tab>
	</Tabs>
</Story>
<Story
	name="With seriesOrder and seriesColors"
	args={{
		x: 'x',
		y: 'y',
		series: 'series',
		seriesOrder: ['ivory', 'blue', 'violet', 'olive'],
		seriesColors: { ivory: 'primary', blue: 'secondary', violet: 'accent', olive: 'negative' }
	}}
/>

Checklist

  • [ ] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [ ] I have added a changeset
  • [ ] I have added to the docs where applicable
  • [ ] I have added to the VS Code extension where applicable

@zachstence zachstence changed the title Feat/2499 theming color names in props [Theming] Use color names in props Nov 13, 2024
@zachstence zachstence merged commit 0d2d8d0 into feat/2499-theming Nov 19, 2024
9 of 10 checks passed
@zachstence zachstence deleted the feat/2499-theming_color-names-in-props branch November 19, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants