-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Theming] Use color names in props #2776
Merged
zachstence
merged 57 commits into
feat/2499-theming
from
feat/2499-theming_color-names-in-props
Nov 19, 2024
Merged
[Theming] Use color names in props #2776
zachstence
merged 57 commits into
feat/2499-theming
from
feat/2499-theming_color-names-in-props
Nov 19, 2024
+2,023
−1,277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver for data-theme
zachstence
changed the title
Feat/2499 theming color names in props
[Theming] Use color names in props
Nov 13, 2024
ItsMeBrianD
requested changes
Nov 18, 2024
packages/ui/core-components/src/lib/unsorted/ui/QueryViewerSupport/prismtheme.css
Show resolved
Hide resolved
packages/ui/core-components/src/lib/unsorted/viz/bubble/BubbleChart.svelte
Outdated
Show resolved
Hide resolved
ItsMeBrianD
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the usage of
color
/colorPalette
/colorScale
names in propsE.g.
Checklist
[ ] For UI or styling changes, I have added a screenshot or gif showing before & after[ ] I have added a changeset[ ] I have added to the docs where applicable[ ] I have added to the VS Code extension where applicable