Implements rules persistence #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavo-iniguez-goya
added a commit
that referenced
this pull request
Dec 9, 2020
If for some reason a Regex type rule can not be parsed, opensnitchd panics and exit. We drop regex.MustCompile() in favor of regex.Compile(), and in case of failure we just drop the packet. In either case, the daemon should not panic but it should not received an invalid rule either, specially from the UI. Closes #4
gustavo-iniguez-goya
added a commit
that referenced
this pull request
Dec 9, 2020
As commented here #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rules persistence using a sqlite database.
I don't know if you want to save all decisions (allow/deny once/all).