Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: verbose logs display with FATAL option #320

Closed
leejw51crypto opened this issue Jul 19, 2021 · 9 comments · Fixed by #343
Closed

Problem: verbose logs display with FATAL option #320

leejw51crypto opened this issue Jul 19, 2021 · 9 comments · Fixed by #343
Assignees
@leejw51crypto
Labels
enhancement New feature or request

Comments

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Jul 19, 2021 •
edited
Loading

only display under debug option

INFO[0005] [GRPC Web] HTTP POST mounted on /ethermint.evm.v1alpha1.Query/BlockLogs
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.mint.v1beta1.Query/AnnualProvisions
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.mint.v1beta1.Query/Params
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.mint.v1beta1.Query/Inflation
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.upgrade.v1beta1.Query/UpgradedConsensusState
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.upgrade.v1beta1.Query/ModuleVersions
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.upgrade.v1beta1.Query/CurrentPlan
INFO[0005] [GRPC Web] HTTP POST mounted on /cosmos.upgrade.v1beta1.Query/AppliedPlan
t=2021-07-19T15:55:10+0900 lvl=dbug msg="Served net_version" conn=127.0.0.1:62759 reqid=1342594436 t="89µs"
t=2021-07-19T15:55:11+0900 lvl=dbug msg="Served eth_blockNumber" conn=127.0.0.1:62759 reqid=5289655945226718 t=3.2395ms
t=2021-07-19T15:55:11+0900 lvl=dbug msg="Served eth_getBalance"  conn=127.0.0.1:62759 reqid=1342593594       t=2.0645ms
t=2021-07-19T15:55:11+0900 lvl=dbug msg="Served eth_getBlockByNumber" conn=127.0.0.1:62761 reqid=1342593639       t=2.206708ms
t=2021-07-19T15:55:11+0900 lvl=dbug msg="Served net_version"          conn=127.0.0.1:62761 reqid=1342594437       t="42.833µs"
@leejw51crypto leejw51crypto self-assigned this Jul 19, 2021
@leejw51crypto
Copy link
Contributor Author

leejw51crypto commented Jul 19, 2021 •
edited
Loading

working now
setting go-ethereum logger to use cosmos one

@leejw51crypto leejw51crypto added the enhancement New feature or request label Jul 19, 2021
@leejw51crypto
Copy link
Contributor Author

leejw51crypto commented Jul 19, 2021 •
edited
Loading

and
1.
ethlog.Root().SetHandler(ethlog.StdoutHandler)
2.
log "github.com/xlab/suplog"

@leejw51crypto
Copy link
Contributor Author

leejw51crypto commented Jul 19, 2021 •
edited
Loading

in start.go

will connect cosmos log option, that will minimize current source modification

	// test code
	// ethlog.Root().SetHandler(ethlog.StdoutHandler)
	suplog.DefaultLogger.SetLevel(suplog.FatalLevel)

@leejw51crypto
Copy link
Contributor Author

almost done, refactoring now

@fedekunze
Copy link
Contributor

we should remove log "github.com/xlab/suplog" from the codebase altogetherer

@leejw51crypto
Copy link
Contributor Author

ok, i will replace suplog with default logger

@leejw51crypto
Copy link
Contributor Author

removed suplog, tidy up now

leejw51crypto added a commit to leejw51crypto/ethermint that referenced this issue Jul 21, 2021
@leejw51crypto
Problem: verbose logs display with FATAL option (fix evmos#320)
e61cbcb 
add my script

increase amount for metamask

add run

amount ok

hide log

show info

my logger

hook log

revive eth log

tidy up

use suplog

log replace ok

removed suplog

tidy up

tidy up

fix compile

remove sh

tidy up

tidy up
@leejw51crypto
Copy link
Contributor Author

in code-review

@fedekunze fedekunze mentioned this issue Jul 23, 2021
Merged
11 tasks
@leejw51crypto
Copy link
Contributor Author

i'll try override this one,
ethlog.Root().SetHandler(ethlog.StdoutHandler)

fedekunze added a commit that referenced this issue Aug 19, 2021
@fedekunze @leejw51crypto
server: logger handler (#343)
d068f5b 
* Problem: verbose logs display with FATAL option (fix #320)
add my script

increase amount for metamask

add run

amount ok

hide log

show info

my logger

hook log

revive eth log

tidy up

use suplog

log replace ok

removed suplog

tidy up

tidy up

fix compile

remove sh

tidy up

tidy up

* logger handler

* fix

* fix eth log override (#371)

remove redundant log

tidy up

* log test

* c++

Co-authored-by: jongwhan lee <jonghwan@crypto.com>
Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leejw51crypto leejw51crypto

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: logger handler evmos/ethermint
2 participants
@fedekunze @leejw51crypto