Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

server: logger handler #343

Merged
merged 13 commits into from
Aug 19, 2021
Merged

server: logger handler #343

merged 13 commits into from
Aug 19, 2021

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Jul 23, 2021

closes #320

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

leejw51crypto and others added 2 commits July 21, 2021 17:00
add my script

increase amount for metamask

add run

amount ok

hide log

show info

my logger

hook log

revive eth log

tidy up

use suplog

log replace ok

removed suplog

tidy up

tidy up

fix compile

remove sh

tidy up

tidy up
@fedekunze
Copy link
Contributor Author

@leejw51crypto can you try testing this? I think it's a better option to pass the logger around

server/start.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #343 (43879ea) into main (ea3ec3b) will decrease coverage by 0.00%.
The diff coverage is 47.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   50.39%   50.38%   -0.01%     
==========================================
  Files          50       51       +1     
  Lines        4951     5007      +56     
==========================================
+ Hits         2495     2523      +28     
- Misses       2349     2374      +25     
- Partials      107      110       +3     
Impacted Files Coverage Δ
x/evm/handler.go 3.33% <0.00%> (-0.84%) ⬇️
x/evm/types/utils.go 61.11% <ø> (+1.11%) ⬆️
log/handler.go 55.55% <55.55%> (ø)
app/ante/ante.go 48.19% <63.63%> (+0.14%) ⬆️

@github-actions github-actions bot added the C:JSON-RPC JSON-RPC client label Aug 19, 2021
@fedekunze fedekunze marked this pull request as ready for review August 19, 2021 16:43
@fedekunze fedekunze enabled auto-merge (squash) August 19, 2021 16:49
@fedekunze fedekunze merged commit d068f5b into main Aug 19, 2021
@fedekunze fedekunze deleted the fedekunze/logger branch August 19, 2021 16:55
yihuang referenced this pull request in yihuang/ethermint Sep 12, 2023
* Problem: no api to convert native events to logs

Solution:
- add event converters

* convert after commit

* Update CHANGELOG.md

Signed-off-by: mmsqe <mavis@crypto.com>

---------

Signed-off-by: mmsqe <mavis@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: verbose logs display with FATAL option
3 participants