Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

eth_call panic in some access list logic #335

Closed
yihuang opened this issue Jul 21, 2021 · 3 comments · Fixed by #348
Closed

eth_call panic in some access list logic #335

yihuang opened this issue Jul 21, 2021 · 3 comments · Fixed by #348
Assignees

Comments

@yihuang
Copy link
Contributor

yihuang commented Jul 21, 2021

System info: ethermint main

Steps to reproduce:

  1. start devnet
  2. deploy the test contract: https://gist.github.com/yihuang/428bf0e6fef9881db347024a1ef2866f
  3. call the approve method

Expected behavior: should success

Actual behavior: estimateGas fail, error message shows panic happens in this line of code: https://github.com/ethereum/go-ethereum/blob/v1.10.4/core/vm/operations_acl.go#L49

Additional info:

@FrancoCRO
Copy link

@yihuang
Copy link
Contributor Author

yihuang commented Jul 24, 2021

Hmm, I think I got the basic idea what's going wrong, PrepareAccessList is called in ante handler, but not in eth_call or eth_estimateGas, since it don't call ante handler.
I think we should move it into ApplyMessage.

@leejw51crypto
Copy link
Contributor

yihuang referenced this issue in yihuang/ethermint Aug 16, 2021
fedekunze added a commit that referenced this issue Aug 16, 2021
Closes: #335

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants