prepare access list for eth_call #348
Conversation
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 50.68% 50.72% +0.04%
==========================================
Files 49 49
Lines 4881 4885 +4
==========================================
+ Hits 2474 2478 +4
Misses 2300 2300
Partials 107 107
|
yihuang
changed the title
|
Checked that this PR resolves the problem |
| @@ -70,7 +70,6 @@ func NewAnteHandler( | |||
| NewEthNonceVerificationDecorator(ak), | |||
| NewEthGasConsumeDecorator(ak, bankKeeper, evmKeeper), | |||
| NewCanTransferDecorator(evmKeeper), | |||
| NewAccessListDecorator(evmKeeper), | |||
There was a problem hiding this comment.
what is the issue with this decorator? the logic is pretty much the same one
There was a problem hiding this comment.
The issue is ante handler is not executed for eth_call, which is handled by grpc query.
There was a problem hiding this comment.
ok that makes sense. Why aren't we using the Simulate gRPC method again? then we could easily solve this issue from arising in the future if we add more logic to the ante handler
There was a problem hiding this comment.
Simulate don't support execute on historical block height, and cosmos-sdk team seems reluctant to support that cosmos/cosmos-sdk#9636 (comment).
There was a problem hiding this comment.
Also to support eth_call with simulate, we need to change the ante handler logic a little bit, since in eth_call the MsgEthereumTx is not signed, and from could be empty.
|
we should add additional notes on the code about this logic but will merge this to speed up things. Please add another PR describing the rationale |
Sure, I just added a comment, also rebased to recent main branch. |
yihuang
force-pushed
the
fix-access-list
branch
from
2959d07 to
2758671
Compare
* Problem: event converter don't have to be global Solution: - support custom event converter on each ExecuteNativeAction call. * remove ExtStateDB interface * fix build
Closes: #335
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)