-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enforce prettier and eslint #3014
Conversation
Nice! The CI fails as expected here ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mattjennings We expect the CI to balk at the moment because we haven't run this yet correct (at least that's what appears to be happening at the moment)
@eonarheim yup - that's in #3015. So if you approve that PR we should see the checks run & hopefully pass, then we can merge it into this PR so we can ignore the commit before merging everything altogether into main. |
Deploying excaliburjs with
|
Latest commit: |
8b8ae1f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://af883000.excaliburjs.pages.dev |
Branch Preview URL: | https://fix-2378.excaliburjs.pages.dev |
===:clipboard: PR Checklist :clipboard:===
==================
See issue #2378
src/engine
, and also remove rules that are handled by prettierall
andall:ci
scriptsI separated the commit that runs the format & lint on all files into #3015 so the config can be easily reviewed here.
Once we're happy with this, we can merge that PR into this one and ignore the commit(s) using
git blame --ignore-rev
to remove it from git blame history.